Additions to configuration logic#18
Open
Snowman0602 wants to merge 2 commits intojonasblunck:masterfrom
Open
Conversation
added 2 commits
May 26, 2023 12:47
This could be expanded in files and other areas of the configuration file.
Could be expanded to be used across all folder paths read from the configuration file, but I'll leave that to someone more familiar with the code base.
Owner
|
I think this is a good idea! Can you also add some unit tests to ConfigFileTests for these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make it easier to use a standard configuration file across multiple projects. There is further room for improvement, but I wanted to show you what I put in place and allow you to update it further if you wanted to support it.