Feature/delete users by alternate ids #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dominicfollett I realize it's been a long time on this PR but if you are still interested in it then please rebase on latest main. There will be some conflicts but hopefully not too bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I am not sure if this is something you might consider, but we recently had the need to delete users by braze id and/or alias. We forked your client and made the additions if you would like to include them?
We kept the original function name unchanged so as to be backward compatible, we added two extra functions that allow you to delete explicitly by braze id or alias.
I also understand you might want to take a completely different approach, and would be happy to make any changes you suggest.