Enable all cops, but explicitly opt each file out (mongodb#5608)

The idea here being that we can go in and opt each file in as we work on it
johnnyshields · Apr 19, 2023 · dc80853 · dc80853
1 parent 344ee2d
commit dc80853
Show file tree

Hide file tree

Showing 1,008 changed files with 1,019 additions and 20 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,5 +1,3 @@
-inherit_from: .rubocop_todo.yml
-
 require:
   - rubocop-performance
   - rubocop-rails
@@ -10,46 +8,48 @@ AllCops:
   TargetRubyVersion: 2.6
   NewCops: enable
   Exclude:
-    - 'spec/shared/lib/mrss/**/*'
+    - 'spec/shared/**/*'
     - 'vendor/**/*'
+    - 'tmp/**/*'
+    - 'test-apps/**/*'
 
 # -----------------------------------
 # TODO: Enable and fix the cops below
 # -----------------------------------
 
 Gemspec:
-  Enabled: false
+  Enabled: true
 
 Layout:
-  Enabled: false
+  Enabled: true
 
 Lint:
-  Enabled: false
+  Enabled: true
 
 Metrics:
-  Enabled: false
+  Enabled: true
 
 Naming:
-  Enabled: false
+  Enabled: true
 
 Performance:
-  Enabled: false
+  Enabled: true
 
 Rake:
-  Enabled: false
+  Enabled: true
 
 Rails:
-  Enabled: false
+  Enabled: true
 
 RSpec:
-  Enabled: false
+  Enabled: true
 
 Security:
   Exclude:
     - 'spec/**/*'
 
 Style:
-  Enabled: false
+  Enabled: true
 
 # --------------------------------------
 # Cops below this line set intentionally

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gemspec

diff --git a/Rakefile b/Rakefile
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "bundler"
 require "bundler/gem_tasks"

diff --git a/examples/mongoid_test.rb b/examples/mongoid_test.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid'
 require 'mongoid/support/query_counter'

diff --git a/gemfiles/bson_master.gemfile b/gemfiles/bson_master.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 gemspec path: '..'
 

diff --git a/gemfiles/bson_min.gemfile b/gemfiles/bson_min.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 gemspec path: '..'
 

diff --git a/gemfiles/driver_master.gemfile b/gemfiles/driver_master.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 gem 'bson', git: "https://github.com/mongodb/bson-ruby", branch: '4-stable'

diff --git a/gemfiles/driver_master_jruby.gemfile b/gemfiles/driver_master_jruby.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 # Due to https://github.com/jruby/jruby/issues/5292 /

diff --git a/gemfiles/driver_min.gemfile b/gemfiles/driver_min.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 gem 'mongo', git: "https://github.com/mongodb/mongo-ruby-driver", branch: '2.18-stable'

diff --git a/gemfiles/driver_min_jruby.gemfile b/gemfiles/driver_min_jruby.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 # Due to https://github.com/jruby/jruby/issues/5292 /

diff --git a/gemfiles/driver_oldstable.gemfile b/gemfiles/driver_oldstable.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 gem 'mongo', git: "https://github.com/mongodb/mongo-ruby-driver", branch: '2.18-stable'

diff --git a/gemfiles/driver_oldstable_jruby.gemfile b/gemfiles/driver_oldstable_jruby.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 # Due to https://github.com/jruby/jruby/issues/5292 /

diff --git a/gemfiles/driver_stable.gemfile b/gemfiles/driver_stable.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 gem 'mongo', git: "https://github.com/mongodb/mongo-ruby-driver", branch: '2.18-stable'

diff --git a/gemfiles/driver_stable_jruby.gemfile b/gemfiles/driver_stable_jruby.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 # Due to https://github.com/jruby/jruby/issues/5292 /

diff --git a/gemfiles/i18n-1.0.gemfile b/gemfiles/i18n-1.0.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source "https://rubygems.org"
 
 gem 'actionpack'

diff --git a/gemfiles/rails-5.2.gemfile b/gemfiles/rails-5.2.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gem 'actionpack', '~> 5.2'

diff --git a/gemfiles/rails-6.0.gemfile b/gemfiles/rails-6.0.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gem 'actionpack', '~> 6.0'

diff --git a/gemfiles/rails-6.1.gemfile b/gemfiles/rails-6.1.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gem 'actionpack', '~> 6.1'

diff --git a/gemfiles/rails-7.0.gemfile b/gemfiles/rails-7.0.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gem 'actionpack', '~> 7.0'

diff --git a/gemfiles/rails-master.gemfile b/gemfiles/rails-master.gemfile
@@ -1,3 +1,4 @@
+# rubocop:todo all
 source 'https://rubygems.org'
 
 gem 'actionpack', git: 'https://github.com/rails/rails'

diff --git a/gemfiles/standard.rb b/gemfiles/standard.rb
@@ -1,3 +1,4 @@
+# rubocop:todo all
 def standard_dependencies
   gem 'rake'
 

diff --git a/lib/mongoid.rb b/lib/mongoid.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "forwardable"
 require "time"

diff --git a/lib/mongoid/association.rb b/lib/mongoid/association.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/accessors'
 require 'mongoid/association/builders'

diff --git a/lib/mongoid/association/accessors.rb b/lib/mongoid/association/accessors.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/bindable.rb b/lib/mongoid/association/bindable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/builders.rb b/lib/mongoid/association/builders.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/constrainable.rb b/lib/mongoid/association/constrainable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/depending.rb b/lib/mongoid/association/depending.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/eager.rb b/lib/mongoid/association/eager.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/eager_loadable.rb b/lib/mongoid/association/eager_loadable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "mongoid/association/eager"
 

diff --git a/lib/mongoid/association/embedded.rb b/lib/mongoid/association/embedded.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/embedded/cyclic'
 require 'mongoid/association/embedded/eager'

diff --git a/lib/mongoid/association/embedded/batchable.rb b/lib/mongoid/association/embedded/batchable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/cyclic.rb b/lib/mongoid/association/embedded/cyclic.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/eager.rb b/lib/mongoid/association/embedded/eager.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embedded_in.rb b/lib/mongoid/association/embedded/embedded_in.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/embedded/embedded_in/binding'
 require 'mongoid/association/embedded/embedded_in/buildable'

diff --git a/lib/mongoid/association/embedded/embedded_in/binding.rb b/lib/mongoid/association/embedded/embedded_in/binding.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embedded_in/buildable.rb b/lib/mongoid/association/embedded/embedded_in/buildable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embedded_in/proxy.rb b/lib/mongoid/association/embedded/embedded_in/proxy.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embeds_many.rb b/lib/mongoid/association/embedded/embeds_many.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/embedded/embeds_many/binding'
 require 'mongoid/association/embedded/embeds_many/buildable'

diff --git a/lib/mongoid/association/embedded/embeds_many/binding.rb b/lib/mongoid/association/embedded/embeds_many/binding.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embeds_many/buildable.rb b/lib/mongoid/association/embedded/embeds_many/buildable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embeds_many/proxy.rb b/lib/mongoid/association/embedded/embeds_many/proxy.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/embedded/batchable'
 

diff --git a/lib/mongoid/association/embedded/embeds_one.rb b/lib/mongoid/association/embedded/embeds_one.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/embedded/embeds_one/binding'
 require 'mongoid/association/embedded/embeds_one/buildable'

diff --git a/lib/mongoid/association/embedded/embeds_one/binding.rb b/lib/mongoid/association/embedded/embeds_one/binding.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embeds_one/buildable.rb b/lib/mongoid/association/embedded/embeds_one/buildable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/embedded/embeds_one/proxy.rb b/lib/mongoid/association/embedded/embeds_one/proxy.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/macros.rb b/lib/mongoid/association/macros.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/many.rb b/lib/mongoid/association/many.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/marshalable.rb b/lib/mongoid/association/marshalable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/nested.rb b/lib/mongoid/association/nested.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/nested/nested_buildable'
 require 'mongoid/association/nested/many'

diff --git a/lib/mongoid/association/nested/many.rb b/lib/mongoid/association/nested/many.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/nested/nested_buildable.rb b/lib/mongoid/association/nested/nested_buildable.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/nested/one.rb b/lib/mongoid/association/nested/one.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/one.rb b/lib/mongoid/association/one.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/options.rb b/lib/mongoid/association/options.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association

diff --git a/lib/mongoid/association/proxy.rb b/lib/mongoid/association/proxy.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "mongoid/association/marshalable"
 

diff --git a/lib/mongoid/association/referenced.rb b/lib/mongoid/association/referenced.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'mongoid/association/referenced/auto_save'
 require 'mongoid/association/referenced/counter_cache'

diff --git a/lib/mongoid/association/referenced/auto_save.rb b/lib/mongoid/association/referenced/auto_save.rb
@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module Mongoid
   module Association