-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub actions #10
Fix GitHub actions #10
Conversation
ae4be4f
to
0bacf0e
Compare
0bacf0e
to
ca7d69d
Compare
Now this works. Regarding the formatting rules: Would you mind if we remove |
I added the same pre-commit hook as in mlx-swift, so that you can run the following command to format before committing: |
You can remove it. |
Okay, I think this is ready to go. |
@johnmai-dev, once you're able to merge this, I'll rebase my previous PR to make it easier for @pcuenca to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
- name: Select Xcode | ||
run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode }}.app | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove Select Xcode
? Previously, it was needed to specify xcode for version 5.8. @DePasqualeOrg
The current GitHub actions appear to be failing, maybe because they include Swift 5.8. I also included a swift-format step.