Added fix to prevent Gnome Shell crash while playing videos on Chromium/Chrome#48
Open
nestorrente wants to merge 1 commit into
Open
Added fix to prevent Gnome Shell crash while playing videos on Chromium/Chrome#48nestorrente wants to merge 1 commit into
nestorrente wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a little fix in order to prevent a Gnome Shell crash when playing videos (i.e. YouTube videos) on Google Chrome or Chromium browser.
The crash was caused by Chromium's MPRIS implementation, which returns
artistfield as astringinstead of an array ofstring. More info available here: https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1835623This change allows Laine to read both
stringand array ofstringvalues.I know this is more a Chromium's bug instead of a Laine's bug, but I use Chrome and Laine every day and this crash was bothering me so much 😅
Thank you very much for your great work!