Skip to content

Adds explicit annotation to allow strict mode invocation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithl8041 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds explicit annotation to allow strict mode invocation #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db268bd
Adds explicit annotation to allow strict mode invocation
Jul 1, 2016
a044d18
Added missing closing bracket to strict mode invocation
Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion angular-appinsights.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

})

.run(function($rootScope, $route, $location, insights) {
.run(['$rootScope', '$route', '$location', 'insights', function ($rootScope, $route, $location, insights) {
Copy link

@seanfisher seanfisher Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this also then require a closing ] somewhere?

Copy link
Author

@keithl8041 keithl8041 Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Now added.

$rootScope.$on('$locationChangeSuccess', function() {
var pagePath;
try {
Expand Down