Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented support for Jira Personal Access Tokens (PAT) #3849

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

suabo
Copy link

@suabo suabo commented Jan 8, 2025

Introduced a new option to use Personal Access Tokens (PAT) for Jira authentication. Updated relevant configurations, models, and request headers to support this feature. This enhances security and provides an alternative to basic authentication.

Issues Resolved

#3808

Introduced a new option to use Personal Access Tokens (PAT) for Jira authentication. Updated relevant configurations, models, and request headers to support this feature. This enhances security and provides an alternative to basic authentication.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there suabo! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@johannesjo
Copy link
Owner

We probably should change the text to something that more actually reflects, who really needs this (as most people don't). Maybe "Personal Access Token (Legacy)"? Maybe you have a better suggestion @suabo ?

Copy link

@jschroed jschroed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested these changes with my Jira instance but I think it will resolve my problem.

I'm not sure if we want the packages updated as part of this and I left a comment about it.

@suabo
Copy link
Author

suabo commented Jan 8, 2025

Calling it legacy is fine for me. I don't know where to change the text. Are you gonna change it when you merge it or should I include the change here in the PR?

@johannesjo
Copy link
Owner

I can also change it!

@johannesjo
Copy link
Owner

Thank you!

@johannesjo johannesjo merged commit 28975ff into johannesjo:master Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants