fix: Fix exception thrown when Edge executable is not found (shaka-pr…

…oject#62)
joeyparrish · Sep 8, 2023 · fd3ff72 · fd3ff72
1 parent db796b9
commit fd3ff72
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 16 deletions.
diff --git a/index.js b/index.js
@@ -300,7 +300,7 @@ const LocalWebDriverChromeHeadless = generateSubclass(
 // that explicitly.  This works around the following edgedriver bug:
 // https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1710724173
 const edgeOptions = {};
-const edgeBinary = which.sync('microsoft-edge');
+const edgeBinary = which.sync('microsoft-edge', {nothrow: true});
 if (edgeBinary) {
   edgeOptions['ms:edgeOptions'] = {
     binary: edgeBinary,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -18,9 +18,9 @@
   "author": "Joey Parrish <[email protected]>",
   "dependencies": {
     "lodash": "^4.17.21",
-    "node-which": "^1.0.0",
     "wd": "^1.14.0",
-    "webdriver-installer": "^1.1.9"
+    "webdriver-installer": "^1.1.9",
+    "which": "^4.0.0"
   },
   "peerDependencies": {
     "karma": "^6.2.0"