PDBWriter: replace Assert with LogError #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierpinho
commented
Dec 11, 2024
| @@ -402,7 +393,7 @@ string BuildFileNameFromTypeName(TypeDefinitionHandle handle) | |||
| var method = function.MoveNextMethod ?? function.Method; | |||
| var methodHandle = (MethodDefinitionHandle)method!.MetadataToken; | |||
| sequencePoints.TryGetValue(function, out var points); | |||
| ProcessMethod(methodHandle, document, points, syntaxTree); | |||
| ProcessMethod(methodHandle, document, points, file.FileName); | |||
There was a problem hiding this comment.
syntaxTree was unused. Replaced it with FileName for logging purposes.
|
cc'ing @DavidBakerEffendi, @AndreiDreyer, since I can't add reviewers. |
DavidBakerEffendi
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed it was crashing when processing https://www.nuget.org/packages/System.Security.Principal.Windows, although exclusively on this file:
Since the remaining files are OK, figured we should at least start by not crashing the entire process.