Bug in most_common_interests_with(user) method definition corrected
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected `most_common_interests_with(user)` method definition is exactly the same as in the book (page8).
The same result as the proposed correction would give a method which takes `user_id = user["id"]`argument instead of a dict type `user` argument. However, in that case the code that would be iterating through all the users to display the results would be less clean than in case of `user` argument:
- For `user` argument:
```python
for user in users:
print most_common_interests_with(user)
```
For `user_id` argument:
```python
for user_id in range(len(users)):
print most_common_interests_with(user_id)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected
most_common_interests_with(user)method definition is exactly the same as in the book (page8).The same result as the proposed correction would give a method which takes
user_id = user["id"]argument instead of a dict typeuserargument. However, in that case the code that would be iterating through all the users to display the results would be less clean:userargument:user_idargument: