FEAT - allow setting of custom csv engine via context #10
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for the passing of a Custom CSV class (aka a CSV Engine) to replace the custom ruby stdlib
CSVclass. The initial reason for requiring this feature is that so we can pass a custom CSV Engine which extends the stdlib version to do some pre-processing of the csv object. In our case that is handling issues relating tobyte_order_prefixes.I have made the custom CSV Engine an option via the
contexthash as I wanted to avoid breaking existing code which expects the positional arguments in a certain order. I also thought using a keyword arguments might be a bit confusing on top of having a context hash.