Update VariantProp type merging logic for Compose interface
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lunelson is attempting to deploy a commit to the cva Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @lunelson! Bit stretched for time at the moment but I'll try to get around to testing this. Really appreciate the contribution 🙏 |
joe-bell
reviewed
Apr 4, 2024
- update Compose interface to use new MergeVariantProp utility type - clean up some other types
lunelson
force-pushed
the
variant-prop-type-merging-logic
branch
from
506d2ad to
b61bf93
Compare
|
Any plans to merge? Seems like a must have feature for typescript ppl |
joe-bell
reviewed
Dec 5, 2024
Signed-off-by: Lu Nelson <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily addresses the following issue, updating the variant prop merging logic that is applied by the
Composeinterface, so that the union of available variant prop names is correct.#256
There are also some secondary simplifications of types, and application of
unknownin place ofany.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).