feat: Windows support — build.ps1, .gitattributes, and Dockerfile fixes#3814
Closed
pasmud wants to merge 1 commit into
Closed
feat: Windows support — build.ps1, .gitattributes, and Dockerfile fixes#3814pasmud wants to merge 1 commit into
pasmud wants to merge 1 commit into
Conversation
Add three changes to make camofox-browser buildable on Windows: - build.ps1: PowerShell script mirroring the Makefile targets (build, up, down, reset, clean, fetch) for Windows users without make. - .gitattributes: enforce LF line endings for .sh files so shell scripts don't break when run inside Linux containers after a Windows clone. - Dockerfile + Dockerfile.ci: run plugin installer via 'sh' explicitly instead of relying on +x permissions, since Docker COPY on Windows does not preserve executable bits.
Contributor
|
Shipped in v1.11 — thank you! We merged the Windows build support: Release notes: https://github.com/jo-inc/camofox-browser/releases/tag/v1.11.0 |
Contributor
|
Closing since this shipped via #4150 in v1.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes camofox-browser buildable on Windows without
makeor WSL, and prevents shell script line-ending issues that break Docker builds from Windows hosts.Changes
build.ps1(new)PowerShell script mirroring the Makefile targets:
build,up,down,reset,clean, andfetch. Each supports the same parameters, including-Arch,-CamoufoxVersion, and-CamoufoxRelease. Runs on both Windows PowerShell 5.1 and PowerShell 7+..gitattributes(new)Enforces LF line endings for
.shfiles via*.sh text eol=lf. Without this, cloning on Windows with default Git settings can produce CRLF line endings, which breaks shebang lines andset -einside Docker builds. The attribute file ensures Git always checks out shell scripts with LF endings regardless ofcore.autocrlf.Dockerfile fixes
Changed
RUN scripts/install-plugin-deps.shtoRUN sh scripts/install-plugin-deps.shin bothDockerfileandDockerfile.ci. TheCOPYinstruction on Windows does not preserve+xpermission bits, so invoking the script directly can fail during Docker builds. Running it viashis explicit and works across platforms.README.md
Added a Windows subsection under
### Dockerwith usage examples forbuild.ps1and instructions for fixing line endings on existing clones.Testing
Tested end-to-end on Windows 11 with Docker Desktop using the WSL2 backend:
.\build.ps1 fetchdownloads Camoufox and yt-dlp.docker buildcompletes all 14 stages successfully.