-
-
Notifications
You must be signed in to change notification settings - Fork 557
feat: add japanese breeze, bromo, and jakarta themes #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@gfsxyz is attempting to deploy a commit to the tweakcn OSS program Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughA new theme preset called "japanese-breeze" with light and dark color variants has been added to the theme presets file. The preset includes complete color tokens for UI elements, typography, chart colors, sidebar styling, shadows, and spacing. A duplicate entry of the same preset also appears in the file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
utils/theme-presets.ts (1)
3597-3699: Japanese Breeze preset is consistent and completeThe token set (light/dark colors, charts, sidebar, fonts, radius, spacing, shadows) aligns with existing themes and looks ready to use. Only very minor nit:
createdAt: "2025-11-29"is one day ahead of this PR’s creation date; if you rely on that field for sorting/timelines and care about strict chronology, you may want to align it with the actual merge/release date.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
utils/theme-presets.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Vercel Agent Review
🔇 Additional comments (2)
utils/theme-presets.ts (2)
3700-3786: Bromo theme fits the existing preset shapeBromo’s light/dark variants provide a full, coherent token set (background/foreground, charts, sidebar, typography, radius, spacing, shadows) and follow the established naming and value patterns in this file. No structural or correctness issues spotted.
3787-3873: Jakarta theme is well-structured and uses Plus Jakarta Sans as intendedJakarta’s palette and tokens (including charts, sidebar, typography, radius, spacing, shadows) match the ThemePreset shape and other presets’ conventions. The Plus Jakarta Sans font wiring via
"font-sans"matches how similar fonts are specified elsewhere in the file.
New Themes: Japanese Breeze, Bromo, and Jakarta
Adding three new themes inspired by Indonesian and Japanese locations. All themes include full light and dark mode support.
1. Japanese Breeze
A calm, minimalist palette inspired by Japanese bamboo/forest. It uses soft calm green tones to create a peaceful user experience.
2. Bromo
inspired by Bromo National Park, focused on earthy mountain tones and natural landscapes.
3. Jakarta
jakarta city inspired theme using the Plus Jakarta Sans font. Features vibrant Orange and Coastal Blue (jakarta city main color).