Support for building with Emscripten#14
Open
parkertomatoes wants to merge 5 commits intojno6809:masterfrom
Open
Support for building with Emscripten#14parkertomatoes wants to merge 5 commits intojno6809:masterfrom
parkertomatoes wants to merge 5 commits intojno6809:masterfrom
Conversation
Collaborator
|
Merged your changes into my fork and made a release version of it: https://github.com/xesf/jc_reborn |
Collaborator
|
This PR has been applied in these changes: #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated this to run in the browser using Emscripten. It runs well on Chrome and Firefox for me

It still builds under MacOS X using the Linux Makefile (
make -f Makefile.linux), but now it also builds with Emscripten (emmake make -f Makefile.linux).Since the code uses blocking calls to
SDL_DelayI built with Asyncify, and only a few minor changes were required.SDL_Delaywere changed toemscripten_sleepto avoid blocking the main thread.exitwere changed toemscripten_force_exitto avoid exceptions being thrown after exitingAll emscripten-specific changes, including in the Makefile, are made with a preprocessor switch (
#ifdef __EMSCRIPTEN__), so the old functionality isn't affected.UPDATE: Removed main loop refactor after realizing it wasn't necessary when using Asyncify