Added Icon and windows exe properties plus Windows MSI installer build#11
Open
nivs1978 wants to merge 2 commits intojno6809:masterfrom
Open
Added Icon and windows exe properties plus Windows MSI installer build#11nivs1978 wants to merge 2 commits intojno6809:masterfrom
nivs1978 wants to merge 2 commits intojno6809:masterfrom
Conversation
jno6809
reviewed
Oct 19, 2022
| $(shell windres MSWindows\icon.rc -O coff -o icon.res) | ||
| $(shell windres MSWindows\exe_header.rc -O coff -o exe_header.res) | ||
|
|
||
| CFLAGS=-I/include/ -Wall --std=c99 |
Owner
There was a problem hiding this comment.
Normally MinGW maps windows paths to unix-like ones. Using native Windows paths shouldn't be necessary ...
jno6809
reviewed
Oct 19, 2022
| config.o | ||
| config.o \ | ||
| icon.res \ | ||
| exe_header.res |
Owner
There was a problem hiding this comment.
Maybe a minor indentation issue here ? (spaces vs tabs)
jno6809
reviewed
Oct 19, 2022
| int getDayOfYear(); | ||
| int getHour(); | ||
| char *getMonthAndDay(); | ||
| char* concat(char *str1, char *str2); |
jno6809
requested changes
Oct 19, 2022
Owner
jno6809
left a comment
jno6809
left a comment
There was a problem hiding this comment.
Hi Hans,
Thanks for this PR. The only real issue here is the native-windows paths put in the Makefile, which IMHO shouldn't be needed...
On my windows setup, I don't need this for the compilation to be successful...
Have you installed the libSDL in the right directories ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A .bat file have been added for building an MSI using the WiX Tools (needs to be installed first).
The bat file checks a lot of prerequisites before starting the build.
The Makefile.MinGW have been updated to include basic windows exe header (company, product, copyright, version etc.) and an icon as well.
The MSWindows firectory contains windows specific icon files, WiS XML for building the MSI as well as the resource templates for the RES files build during make.
Everything is packed into an MSI that will put jc_reborn.scr + SDL2.dll in the Windows directory and the resource+wav files in c:\sierra\scrantic directory, just like the original. Finally the installer open the screen saver settings dialog for the user to set jc_reborn as the default screensaver.