Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds customizable legend text size functionality to the Legend class by introducing a configurable text_size field. The hardcoded text size value of 20 is replaced with a class field that defaults to 20, maintaining backward compatibility while allowing users to customize the legend text size when creating Legend instances.
Key changes:
- Added
text_sizefield to the Legend dataclass with a default value of 20 - Updated
__setupLegendmethod to use the configurabletext_sizeinstead of hardcoded value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pylibs/plotting/Legend.py | Adds configurable text_size field (default=20) to Legend dataclass and updates SetTextSize call to use this field instead of hardcoded value |
| pylibs/plotting/Sample.py | Changes Logger import from error to fatal - unrelated to the PR's stated purpose |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jniedzie
force-pushed
the
devel_jeremi
branch
from
1c26c6a to
1b4a85f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.