Multiple fixes for osctrl-api and api_tester tool
#765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
osctrl-api
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes multiple issues in the osctrl-api and the api_tester tool, primarily focused on API authentication, endpoint corrections, and improved test flexibility.
Key changes:
- Enhanced the
api_tester.pytool to accept multiple expected HTTP status codes for API tests - Fixed authentication middleware application for the
/checks-authendpoint - Corrected API handler mapping from
CarveShowHandlertoCarveListHandlerfor the carves endpoint - Renamed method calls from
VerifyTypetoVerifyServicein settings handlers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/api_tester.py | Enhanced test framework to support multiple expected status codes, improved documentation, fixed request payload field name from "target" to "identifier", and added 404 as valid response for node/carve endpoints |
| cmd/api/main.go | Applied authentication middleware to /checks-auth endpoint and corrected carves endpoint handler from CarveShowHandler to CarveListHandler |
| cmd/api/handlers/settings.go | Renamed method calls from VerifyType to VerifyService across all settings handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes for
osctrl-apiand api_tester tool