fix: empty path segments produced by build_url()
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing my middleware in another project I noticed that
rustify
will sometimes produce extraneous//
in theUri
produced byhttp::build_url()
.This is due to some unhandled cases where base path, trailing slashes, and path with leading slashes may result in adding empty path segments to the joined path.
Testing & Failure Cases
This PR adds 9 different test cases. Prior to the fix, 3 were failing.
You can checkout f7ab901 and
cargo test
to reproduce.Example
This is an example similar to how I stumbled on this:
This issue doesn't really impact actual HTTP requesting / library usage, but may surprise developers trying to write tests. :)
Fix
build_url()
is adjust to better avoid empty path segments by:/
from the endpoint/relative path (to avoid adding an empty path segment)