Repository navigation
feat(review): only request changes for security issues - #35
Merged
Merged
Conversation
## What/Why Post reviews with the COMMENT event unless a finding is a security issue. A change request makes me the blocker, while a comment lets the author push updates and other maintainers approve and merge. ## Proof it works pre-commit passes on all files (markdownlint, check json). bats tests/reassess passes (77 tests); the change is docs-only in review/SKILL.md plus the plugin version bump to 0.1.23. ## Risk Low. One added rule in the review skill's drafting section; no scripts change. ## AI role Rule wording drafted by Claude Opus 5.5 from my stated preference after a gemara-website review session; I asked for the change and approved pushing it. ## Review focus Whether "security issue" is scoped clearly enough, or needs examples of what counts. Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
The review skill now posts reviews with the COMMENT event unless a finding is a security issue. A change request makes me the blocker. A comment lets the author push updates and lets other maintainers approve and merge.
Proof it works
The bats suite passes (77 tests). The change is one rule in review/SKILL.md plus the plugin version bump to 0.1.23.
Risk
Low. Docs-only change to the skill; no scripts change.
AI role
Claude Opus 5.5 drafted the rule wording from my stated preference. I reviewed it and asked for the PR.
Review focus
Whether "security issue" is scoped clearly enough or needs examples.