Skip to content

feat(review): stop on merged or closed PRs before reviewing and posting - #34

Merged
jmeridth merged 1 commit into
mainfrom
feat/review-stop-on-merged
Nov 4, 2026
Merged

jmeridth merged 1 commit into
mainfrom
feat/review-stop-on-merged

Conversation

@jmeridth

@jmeridth jmeridth commented Nov 4, 2026

Copy link
Copy Markdown
Owner

What/Why

The review skill now checks PR state at three points: before launching agents, when the orchestrator returns, and right before posting. Reviews were running against PRs that merged mid-review, and one posted after merge because the state check was chained into the post command. The plugin is bumped to 0.1.22.

Proof it works

Docs-only change. pre-commit passes.

Risk

Low. It adds checks to the workflow text and changes no scripts.

AI role

Claude Opus 5.5 drafted the wording from a review of the failed runs. I approved the three edit points before they were made.

Review focus

Whether an already-approved or automerge PR should stop and ask, not just warn.

## What/Why

Check PR state before launching agents, have the orchestrator re-check before returning, and require a standalone state check right before posting. Three reviews in one session were wasted on PRs that merged mid-review, and one was posted after merge because the state check was chained into the post command.

## Proof it works

pre-commit passes (markdownlint, check json). Docs-only change to SKILL.md; the bats suite covers reassess only and was not run (bats not installed locally).

## Risk

Low. Adds checks to the review workflow; no scripts change.

## AI role

Wording drafted by Claude Opus 5.5 from the session's failure analysis; human approved the three edit points before they were made.

## Review focus

Whether "say so before launching" for approved or automerge PRs should instead stop and ask.

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Nov 4, 2026
@github-actions github-actions Bot added feature release Merging this PR triggers a release labels Nov 4, 2026
@jmeridth
jmeridth marked this pull request as ready for review November 4, 2026 01:55
@jmeridth
jmeridth merged commit b8446e3 into main Nov 4, 2026
5 checks passed
@jmeridth
jmeridth deleted the feat/review-stop-on-merged branch November 4, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature release Merging this PR triggers a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant