Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement access_id method to fetch via /object/{id}/access/{access_id}. #84

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Implement access_id method to fetch via /object/{id}/access/{access_id}. #84

merged 2 commits into from
Jul 23, 2022

Conversation

uwwint
Copy link

@uwwint uwwint commented Jul 12, 2022

This implements the access_id method in DRS, as per: https://ga4gh.github.io/data-repository-service-schemas/preview/develop/docs/#tag/Service-Info/operation/GetServiceInfo
at least one of access_url or access_id should be represented. Some argue that either should be the case ga4gh/data-repository-service-schemas#360
whatever the final resolution will be on the ticket - In the absence of access_url using the access endpoint is definitely up to spec ;).

KR,
Uwe

(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    use any DRS wich uses access_id (I have my own little not yet public one).

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@jmchilton jmchilton merged commit a6d8952 into jmchilton:drs Jul 23, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants