Use hidden instead of visible as attribute name for consistency

jmchilton · Feb 5, 2025 · fc88801 · fc88801
1 parent ba48c34
commit fc88801
Show file tree

Hide file tree

Showing 22 changed files with 24 additions and 24 deletions.
diff --git a/config/plugins/visualizations/jqplot/jqplot_bar/config/jqplot_bar.xml b/config/plugins/visualizations/jqplot/jqplot_bar/config/jqplot_bar.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Bar diagram (jqPlot)" visible="false">
+<visualization name="Bar diagram (jqPlot)" hidden="true">
     <macros>
         <import>jqplot_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/jqplot/jqplot_box/config/jqplot_box.xml b/config/plugins/visualizations/jqplot/jqplot_box/config/jqplot_box.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Box plot (jqPlot)" embeddable="false" visible="false">
+<visualization name="Box plot (jqPlot)" embeddable="false" hidden="true">
     <macros>
         <import>../../jqplot_bar/config/jqplot_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/jqplot/jqplot_histogram/config/jqplot_histogram.xml b/config/plugins/visualizations/jqplot/jqplot_histogram/config/jqplot_histogram.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Discrete Histogram (jqPlot)" embeddable="false" visible="false">
+<visualization name="Discrete Histogram (jqPlot)" embeddable="false" hidden="true">
     <macros>
         <import>../../jqplot_bar/config/jqplot_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/jqplot/jqplot_line/config/jqplot_line.xml b/config/plugins/visualizations/jqplot/jqplot_line/config/jqplot_line.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Line chart (jqPlot)" visible="false">
+<visualization name="Line chart (jqPlot)" hidden="true">
     <macros>
         <import>../../jqplot_bar/config/jqplot_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/jqplot/jqplot_scatter/config/jqplot_scatter.xml b/config/plugins/visualizations/jqplot/jqplot_scatter/config/jqplot_scatter.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Scatter plot (jqPlot)" visible="false">
+<visualization name="Scatter plot (jqPlot)" hidden="true">
     <macros>
         <import>../../jqplot_bar/config/jqplot_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_bar/config/nvd3_bar.xml b/config/plugins/visualizations/nvd3/nvd3_bar/config/nvd3_bar.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Bar diagram (NVD3)" visible="false">
+<visualization name="Bar diagram (NVD3)" hidden="true">
     <macros>
         <import>nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_bar_stacked/config/nvd3_bar_stacked.xml b/config/plugins/visualizations/nvd3/nvd3_bar_stacked/config/nvd3_bar_stacked.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Bar Stacked (NVD3)" visible="false">
+<visualization name="Bar Stacked (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_histogram/config/nvd3_histogram.xml b/config/plugins/visualizations/nvd3/nvd3_histogram/config/nvd3_histogram.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Histogram (NVD3)" embeddable="false" visible="false">
+<visualization name="Histogram (NVD3)" embeddable="false" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/...ig/plugins/visualizations/nvd3/nvd3_histogram_discrete/config/nvd3_histogram_discrete.xml b/...ig/plugins/visualizations/nvd3/nvd3_histogram_discrete/config/nvd3_histogram_discrete.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Histogram Discrete (NVD3)" embeddable="false" visible="false">
+<visualization name="Histogram Discrete (NVD3)" embeddable="false" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_horizontal/config/nvd3_horizontal.xml b/config/plugins/visualizations/nvd3/nvd3_horizontal/config/nvd3_horizontal.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Bar Horizontal (NVD3)" visible="false">
+<visualization name="Bar Horizontal (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/...ig/plugins/visualizations/nvd3/nvd3_horizontal_stacked/config/nvd3_horizontal_stacked.xml b/...ig/plugins/visualizations/nvd3/nvd3_horizontal_stacked/config/nvd3_horizontal_stacked.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Bar Horizontal Stacked (NVD3)" visible="false">
+<visualization name="Bar Horizontal Stacked (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_line/config/nvd3_line.xml b/config/plugins/visualizations/nvd3/nvd3_line/config/nvd3_line.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Line chart (NVD3)" visible="false">
+<visualization name="Line chart (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_line_focus/config/nvd3_line_focus.xml b/config/plugins/visualizations/nvd3/nvd3_line_focus/config/nvd3_line_focus.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Line with focus (NVD3)" visible="false">
+<visualization name="Line with focus (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_pie/config/nvd3_pie.xml b/config/plugins/visualizations/nvd3/nvd3_pie/config/nvd3_pie.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Pie chart (NVD3)" visible="false">
+<visualization name="Pie chart (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_scatter/config/nvd3_scatter.xml b/config/plugins/visualizations/nvd3/nvd3_scatter/config/nvd3_scatter.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Scatter plot (NVD3)" visible="false">
+<visualization name="Scatter plot (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_stackedarea/config/nvd3_stackedarea.xml b/config/plugins/visualizations/nvd3/nvd3_stackedarea/config/nvd3_stackedarea.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Stacked area (NVD3)" visible="false">
+<visualization name="Stacked area (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/nvd3/nvd3_stackedarea_full/config/nvd3_stackedarea_full.xml b/config/plugins/visualizations/nvd3/nvd3_stackedarea_full/config/nvd3_stackedarea_full.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Expanded (NVD3)" visible="false">
+<visualization name="Expanded (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/...ig/plugins/visualizations/nvd3/nvd3_stackedarea_stream/config/nvd3_stackedarea_stream.xml b/...ig/plugins/visualizations/nvd3/nvd3_stackedarea_stream/config/nvd3_stackedarea_stream.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Stream (NVD3)" visible="false">
+<visualization name="Stream (NVD3)" hidden="true">
     <macros>
         <import>../../nvd3_bar/config/nvd3_shared.xml</import>
     </macros>

diff --git a/config/plugins/visualizations/pv/config/pv.xml b/config/plugins/visualizations/pv/config/pv.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="PV Protein Viewer">
+<visualization name="PV Protein Viewer" hidden="true">
     <description>PV is a pdb/protein viewer hosted at https://biasmv.github.io/pv/.</description>
     <data_sources>
         <data_source>

diff --git a/config/plugins/visualizations/scatterplot/config/scatterplot.xml b/config/plugins/visualizations/scatterplot/config/scatterplot.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE visualization SYSTEM "../../visualization.dtd">
-<visualization name="Scatterplot" visible="false">
+<visualization name="Scatterplot" hidden="true">
     <description>Creates a 2D-scatterplot from tabular datapoints</description>
     <data_sources>
         <data_source>

diff --git a/lib/galaxy/visualization/plugins/config_parser.py b/lib/galaxy/visualization/plugins/config_parser.py
@@ -81,9 +81,9 @@ def parse_visualization(self, xml_tree):
             returned["embeddable"] = asbool(xml_tree.attrib.get("embeddable"))
 
         # record the visible flag - defaults to true
-        returned["visible"] = True
-        if "visible" in xml_tree.attrib:
-            returned["visible"] = asbool(xml_tree.attrib.get("visible"))
+        returned["hidden"] = False
+        if "hidden" in xml_tree.attrib:
+            returned["hidden"] = asbool(xml_tree.attrib.get("hidden"))
 
         # a (for now) text description of what the visualization does
         description = xml_tree.find("description")

diff --git a/lib/galaxy/visualization/plugins/registry.py b/lib/galaxy/visualization/plugins/registry.py
@@ -233,7 +233,7 @@ def get_visualizations(self, trans, target_object=None, embeddable=None):
         """
         result = []
         for vis_name, vis_plugin in self.plugins.items():
-            if not vis_plugin.config.get("visible"):
+            if vis_plugin.config.get("hidden"):
                 continue
             if embeddable and not vis_plugin.config.get("embeddable"):
                 continue