Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): allow to search for multiple product names #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmagrini
Copy link

@hmagrini hmagrini commented May 2, 2020

Allow to configure multiple product names for the app to use when searching logs. This feature is backwards compatible.

closes #4

@jmarsik
Copy link
Owner

jmarsik commented May 20, 2020

I don't have time to test it. Is it backwards compatible? How does the in operator work when the right side is a string and not an array of strings?

@hmagrini
Copy link
Author

hi @jmarsik!

yes, it's backwards compatible :) The in operator returns True if the substring exists in the string in the right. Conversely, it returns True if the substring is contained within an array. Otherwise, it returns False for both cases https://repl.it/repls/NeglectedCrowdedOperatingsystem

@jmarsik
Copy link
Owner

jmarsik commented May 26, 2020

It's not 100% backward compatible because in the current version there is == comparison, not in comparison. Can you change it so that it uses == comparison when the right side is a simple string and in comparison when it's an array of strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Product names
2 participants