Fix docs imports#22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I failed to notice the examples are broken on gh pages because they can't import
dirconf.This is because I was running
marimo export mdwith--sandbox, which creates a new dedicated isolated environment to run the notebook.I thought this was smart since I could in-line each individual example's dependencies, rather than including them in
pyproject.toml. However, if you do this you need to inline the local package - which means not only addingdirenvto the dependencies table, but also the local path in the sources table.It actually doesn't make sense for these notebooks to be sandboxed since they depend on some local paths (the example config and inputs). So, I'm going to revert to just building the notebooks in the project venv, with an extra dependencies table in
pyproject.toml.