Fix iterator protocol support + npm build scripts #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to abandonment, I’ve forked this and am actively working on it. One thing I’d love is the ability to replace the prototype chain with these. So people doesn’t need to know that performance is drastically improved. |
|
@ScriptedAlchemy Now that I'm back to being knee-deep in JS-land and finding it hard to find a transducer library that's both tiny and maintained (and with an API that desn't drop me into weird typescript config object0 I finally realized I missed your comment after being like "welp, might as well work from my stale PR." i even saw your package in npm, just hadn't looked into it yet 😆 Anyway, sorry it took me 3 years to notice it, but thanks for dropping me the note! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
replaces #38
Ensured that the
.iteratorand.toItermethods are compliant with iterator-protocol by adding a self-returningSymbol.iterator/@@iteratormethod to all returned iterators, rather than just those produced byLazyTransformer. Also added some additional tests to make sure it checks iterators produced fromLazyTransformerandWrappedIterator.I noticed that
dist/transducers.jswas already out of date compared to the source code, so I had also added some build and test scripts, as well as aprepublishscript to ensure dist is built before it's published. Let me know if you'd rather that go in a separate PR and I'll gladly remove them, but I figured it would help keep things in sync between the module/global versions. I didn't check in a new version ofdist/transducers.js, though.