Skip to content

Commit

Permalink
Rename an event handler to be less confusing.
Browse files Browse the repository at this point in the history
Part of #174. Part of #688.
  • Loading branch information
jkomoros committed Mar 30, 2024
1 parent ea2061f commit 05e5cfc
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions src/components/multi-edit-dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,21 @@ class MultiEditDialog extends connect(store)(DialogElement) {
const subtleItems = arrayDiffAsSets(referencesMap[entry[0]], intersectionReferencesMap[entry[0]])[1];
return html`<div>
<label>${entry[1].name} ${help(entry[1].description, false)}</label>
<tag-list .overrideTypeName=${'Reference'} data-reference-type=${entry[0]} .tagInfos=${this._cardTagInfos} .subtleTags=${subtleItems} .defaultColor=${entry[1].color} .tags=${referencesMap[entry[0]] || []} .previousTags=${previousReferencesMap[entry[0]] || []} .editing=${true} .tapEvents=${true} .disableAdd=${true} @tag-tapped=${this._handleTagTapped} @tag-added=${this._handleUnremoveReference} @tag-removed=${this._handleRemoveReference}></tag-list>
<tag-list
.overrideTypeName=${'Reference'}
data-reference-type=${entry[0]}
.tagInfos=${this._cardTagInfos}
.subtleTags=${subtleItems}
.defaultColor=${entry[1].color}
.tags=${referencesMap[entry[0]] || []}
.previousTags=${previousReferencesMap[entry[0]] || []}
.editing=${true}
.tapEvents=${true}
.disableAdd=${true}
@tag-tapped=${this._handleReferenceTagTapped}
@tag-added=${this._handleUnremoveReference}
@tag-removed=${this._handleRemoveReference}>
</tag-list>
</div>`;
})}
<label>Tags</label>
Expand Down Expand Up @@ -232,7 +246,7 @@ class MultiEditDialog extends connect(store)(DialogElement) {
store.dispatch(selectCardToReference(value));
}

_handleTagTapped(e : TagEvent) {
_handleReferenceTagTapped(e : TagEvent) {
//Only add it if not all cards already have it
if (!e.detail.subtle) return;
let refType : ReferenceType | undefined = undefined;
Expand Down

0 comments on commit 05e5cfc

Please sign in to comment.