Optional endpoint argument support #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional endpoint argument to support S3 compatible backups. For AWS S3 endpoint parameter is not needed, use the regions(look at docs) for details since boto can do mapping between region and endpoint for AWS S3
Owner
|
Windows or your editor has added Windows style CTRLF line ending characters to the files you've edited. Where they were formerly UNIX LF line ending characters. Would you mind converting those back to UNIX line endings (perhaps the dos2unix utility)? Right now it looks like (and you have) changed every line in the two files, so its hard to see the actual diff of changes. I think your changes are pretty reasonable, its just difficult to work them through the github PR with the line ending character changes. |
Author
|
Yup, something got messed up in editor and it's not showing diff correctly rather than showing entire file. will fix it this week. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional endpoint argument to support S3 compatible backups. For AWS S3 endpoint parameter is not needed, use the regions(look at docs) for details since boto can do mapping between region and endpoint for AWS S3