feat (rotor): Add localized names for continents, countries, regions, and cities #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeremyanin
changed the title
dmeremyanin
force-pushed
the
rotor-names-localization
branch
from
bbbf64f to
552dd10
Compare
romanlex
approved these changes
Dec 12, 2024
dmeremyanin
force-pushed
the
rotor-names-localization
branch
from
552dd10 to
f08be77
Compare
dmeremyanin
force-pushed
the
rotor-names-localization
branch
from
f08be77 to
935adde
Compare
absorbb
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key improvements to geographical data handling:
namefield existed for cities and countries but was missing for continents and regions. This PR adds thenamefield to continents and regions.MAXMIND_LOCALEenvironment variable. If not set, the default language remains English.The list of available locales can be found here:
https://maxmind.github.io/GeoIP2-node/interfaces/Names.html