fix(screenshot-capture): use dynamic getState to avoid stale state snapshot#17375
Open
Sahitya0805 wants to merge 1 commit intojitsi:masterfrom
Open
fix(screenshot-capture): use dynamic getState to avoid stale state snapshot#17375Sahitya0805 wants to merge 1 commit intojitsi:masterfrom
Sahitya0805 wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ScreenshotCaptureSummaryclass was storing a snapshot of the Redux state in its constructor. This led to "metadata leakage" when a user switched conferences or when JWTs rotated, as the class continued to use the old state for subsequent screenshots.This PR refactors the class to store a reference to the
getStatefunction instead, ensuring that every time a screenshot is processed, it retrieves the most current data from the store.Fixes #17247
Checklist