Skip to content
This repository was archived by the owner on Mar 29, 2018. It is now read-only.

Unified Icon component for web and native - #90

Open
tsareg wants to merge 5 commits into
jitsi:masterfrom
tsareg:fonts
Open

Unified Icon component for web and native#90
tsareg wants to merge 5 commits into
jitsi:masterfrom
tsareg:fonts

Conversation

@tsareg

@tsareg tsareg commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

Now we have generic Icon component which loads Jitsi-specific Ico Moon font icons or Font Awesome font icons.

Also replaced Font-Awesome sources with NPM module.

@tsareg

tsareg commented Aug 16, 2016

Copy link
Copy Markdown
Contributor Author

@yanas, as for our discussion about how to use icons from Jitsi fonts.
Actually, we can use not SVGs, but a font icons with classes. But this will require loading eot/svg/ttf/woff files. Do you think this is a better solution?

@yanas

yanas commented Aug 16, 2016

Copy link
Copy Markdown
Member

@tsareg I read some articles comparing svg and fonts, which I haven't spotted before and I actually don't mind the svg solution. It has it's advantages! We just need to make sure that it has good browser support (from what I read it should be ok, but still I spotted some comments about IE9). Also I read somewhere that some problems were experienced on Android. So let's make sure we check those if we haven't already.

@tsareg

tsareg commented Aug 17, 2016

Copy link
Copy Markdown
Contributor Author

@yanas I've changed code to use font icons instead of svg.
As for Android issue, I expect it's something with react-native-vector-icons lib setup and it's not a part of this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants