fix: no auth subscription must only wait for the expected bundle ID.#47
Open
serejke wants to merge 1 commit intojito-labs:masterfrom
Open
fix: no auth subscription must only wait for the expected bundle ID.#47serejke wants to merge 1 commit intojito-labs:masterfrom
serejke wants to merge 1 commit intojito-labs:masterfrom
Conversation
Author
ab96995 to
0e3e862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When
jito-searcher-cli send-bundleis run in no-auth mode, thebundle_results_subscriptionsearcher-examples/cli/src/main.rs
Line 257 in 3708a1e
emits other searchers' bundles.
The current code subscribes to the only
.next()bundlesearcher-examples/searcher_client/src/lib.rs
Line 122 in ab96995
even though it is not necessarily the signer's bundle.
So the script fails with an error akin to:
(other searcher's failed bundle)
Fix
Expect only the sent bundle by UUID and filter out everything else.