Switch from at_exit to finalizer to avoid squashing test exit code.#16
Open
nmeans wants to merge 1 commit intojimeh:masterfrom
Open
Switch from at_exit to finalizer to avoid squashing test exit code.#16nmeans wants to merge 1 commit intojimeh:masterfrom
nmeans wants to merge 1 commit intojimeh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using at_exit can unintentionally squash the exit status of the including application's test suite, causing the suite to always return an exit status of 0 even when tests are failing. This causes CI platforms like Travis that rely on test exit status for determining the status of a given build. This commit uses a finalizer to trigger the same buffer flush without interfering with test suite exit status.