Skip to content

perf-event-open-sys: add bindings for (arm) armv7l#31

Closed
fritschy wants to merge 1 commit intojimblandy:masterfrom
fritschy:fritschy-add-armv7-bindings
Closed

perf-event-open-sys: add bindings for (arm) armv7l#31
fritschy wants to merge 1 commit intojimblandy:masterfrom
fritschy:fritschy-add-armv7-bindings

Conversation

@fritschy
Copy link

This adds armv7 bindings. (Really just generated and added a couple of lines to existing sources).

Generated binding on raspi-os

Linux raspberrypi 5.15.84-v7+ #1613 SMP Thu Jan 5 11:59:48 GMT 2023 armv7l GNU/Linux

Tested on the same system, but cross compiled with cross-rs and musl.

cargo test results:

$ cargo test
   Compiling bitflags v1.3.2
   Compiling perf-event-open-sys v4.0.0 (/home/m/src/perf-event/perf-event-open-sys)
   Compiling perf-event v0.4.8 (/home/m/src/perf-event/perf-event)
    Finished test [unoptimized + debuginfo] target(s) in 31.55s
     Running unittests src/lib.rs (target/debug/deps/perf_event-1542f7d8622ec449)

running 2 tests
test test_error_code_is_correct ... ok
test simple_build ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

     Running tests/breakpoint.rs (target/debug/deps/breakpoint-a90b7f46d62bb388)

running 2 tests
test data ... ok
test execute ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

     Running unittests src/lib.rs (target/debug/deps/perf_event_open_sys-bef037ddf6f30e62)

running 18 tests
test bindings::bindgen_test_layout___kernel_fd_set ... ok
test bindings::bindgen_test_layout___kernel_fsid_t ... ok
test bindings::bindgen_test_layout_perf_event_attr ... ok
test bindings::bindgen_test_layout_perf_event_attr__bindgen_ty_2 ... ok
test bindings::bindgen_test_layout_perf_event_attr__bindgen_ty_3 ... ok
test bindings::bindgen_test_layout_perf_event_attr__bindgen_ty_4 ... ok
test bindings::bindgen_test_layout_perf_branch_entry ... ok
test bindings::bindgen_test_layout_perf_event_attr__bindgen_ty_1 ... ok
test bindings::bindgen_test_layout_perf_event_header ... ok
test bindings::bindgen_test_layout_perf_event_mmap_page ... ok
test bindings::bindgen_test_layout_perf_event_mmap_page__bindgen_ty_1 ... ok
test bindings::bindgen_test_layout_perf_event_mmap_page__bindgen_ty_1__bindgen_ty_1 ... ok
test bindings::bindgen_test_layout_perf_event_query_bpf ... ok
test bindings::bindgen_test_layout_perf_mem_data_src ... ok
test bindings::bindgen_test_layout_perf_mem_data_src__bindgen_ty_1 ... ok
test bindings::bindgen_test_layout_perf_ns_link_info ... ok
test bindings::bindgen_test_layout_perf_sample_weight ... ok
test bindings::bindgen_test_layout_perf_sample_weight__bindgen_ty_1 ... ok

test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

   Doc-tests perf-event

running 20 tests
test src/hooks.rs - hooks::RealHooks (line 194) ... ok
test src/events.rs - events::Cache (line 213) ... ok
test src/events.rs - events::Breakpoint (line 365) ... ok
test src/events.rs - events::Breakpoint (line 392) ... ok
test src/lib.rs - Builder (line 161) ... ok
test src/lib.rs - Builder (line 169) ... ok
test src/lib.rs - (line 10) ... ok
test src/lib.rs - Builder (line 180) ... ok
test src/lib.rs - Builder<'a>::kind (line 590) ... ok
test src/lib.rs - Counter::read_count_and_time (line 755) ... ok
test src/lib.rs - Counter (line 110) ... ok
test src/lib.rs - Counts (line 351) ... ok
test src/lib.rs - Counts (line 365) ... ok
test src/lib.rs - Counts::get (line 1043) ... ok
test src/lib.rs - Group (line 301) ... ignored
test src/lib.rs - Group (line 307) ... ignored
test src/lib.rs - Group::read (line 894) ... ignored
test src/lib.rs - Counts (line 382) ... ok
test src/lib.rs - Counts::iter (line 1058) ... ok
test src/lib.rs - Group (line 241) ... ok

test result: ok. 17 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out; finished in 23.64s

   Doc-tests perf-event-open-sys

running 1 test
test src/lib.rs - (line 31) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.93s

@fritschy fritschy force-pushed the fritschy-add-armv7-bindings branch from d91e340 to 7f10988 Compare March 27, 2023 08:45
@fritschy
Copy link
Author

Uh, updated author - my bad!

@fritschy fritschy force-pushed the fritschy-add-armv7-bindings branch from 7f10988 to d8c81f0 Compare September 15, 2023 09:10
@jimblandy
Copy link
Owner

I believe this is outdated by #42.

@jimblandy jimblandy closed this Apr 9, 2025
@Phantomical
Copy link
Collaborator

Phantomical commented Apr 9, 2025

I don't think this is covered by #42 - we have aarch64, but not armv7. It is out of date though, so I'll make a new PR that adds the bindings when I have time later tonight.

Phantomical added a commit to Phantomical/perf-event-upstream that referenced this pull request Apr 10, 2025
This reimplements jimblandy#31 using the new regenerate.sh. It makes some guesses
as to what the correct target arch is, but I don't think it does
anything unreasonable here.
Phantomical added a commit to Phantomical/perf-event-upstream that referenced this pull request Apr 10, 2025
This reimplements jimblandy#31 using the new regenerate.sh. It makes some guesses
as to what the correct target arch is, but I don't think it does
anything unreasonable here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants