Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix total time elapsed does not account for all steps #475

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix total time elapsed does not account for all steps #475

merged 3 commits into from
Jan 24, 2025

Conversation

niwa2
Copy link
Contributor

@niwa2 niwa2 commented Jan 24, 2025

Summarize Changes

  1. Fix total time elapsed does not account for all steps like UVR, copying original audio for speaker diarization, VAD, restoring the timestamps after VAD
  2. add some more progress messages to give the user a bit more information

@jhj0517
Copy link
Owner

jhj0517 commented Jan 24, 2025

Thanks. This makes sense, I'll just do some capitalization on a few words.

@jhj0517 jhj0517 added the enhancement New feature or request label Jan 24, 2025
@jhj0517 jhj0517 merged commit 0721cc0 into jhj0517:master Jan 24, 2025
9 checks passed
@niwa2 niwa2 deleted the fix_total_time branch January 24, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhj0517 jhj0517 jhj0517 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niwa2 @jhj0517