-
Notifications
You must be signed in to change notification settings - Fork 3
Add embeddable API, convo persistence & cancel #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jhd3197
wants to merge
2
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| --- | ||
| name: create-pr | ||
| description: Generate a pull request title and description from the current branch's commits. Produces a concise summary, optional feature highlights, and collapsible technical details. | ||
| --- | ||
|
|
||
| # Create PR Description | ||
|
|
||
| Generate a pull request title and description that's scannable, informative, and has just enough personality to feel human. | ||
|
|
||
| ## Instructions | ||
|
|
||
| ### 1. Gather context (do ALL of these) | ||
|
|
||
| Run these commands to build a complete picture before writing anything: | ||
|
|
||
| ```bash | ||
| # Commit overview | ||
| git log main..HEAD --oneline --stat | ||
|
|
||
| # Full diff stat for file-level scope | ||
| git diff main..HEAD --stat | ||
|
|
||
| # Actual code changes — read the diff, don't just skim filenames | ||
| git diff main..HEAD | ||
| ``` | ||
|
|
||
| If the full diff is too large, diff individual areas (backend routes, frontend, storage, etc.) in batches. You must understand **what the code actually does**, not just which files were touched. | ||
|
|
||
| ### 2. Write the PR file | ||
|
|
||
| Write the file to `.pr/YYYY-MM-DD.md` (using today's date). Create the `.pr/` directory if it doesn't exist. If a file for today's date already exists, append a counter: `YYYY-MM-DD-2.md`, `YYYY-MM-DD-3.md`, etc. | ||
|
|
||
| The structure depends on whether the PR introduces user-facing features or is purely internal (refactors, bug fixes, infra). | ||
|
|
||
| #### When the PR has user-facing features: | ||
|
|
||
| ~~~markdown | ||
| # <Title> | ||
|
|
||
| <2-3 sentence summary> | ||
|
|
||
| ### Highlights | ||
|
|
||
| - Highlight 1 | ||
| - Highlight 2 | ||
| - ... | ||
|
|
||
| <details> | ||
| <summary>Technical changes</summary> | ||
|
|
||
| - Detail 1 | ||
| - Detail 2 | ||
| - ... | ||
|
|
||
| </details> | ||
| ~~~ | ||
|
|
||
| #### When the PR is purely internal (no user-facing features): | ||
|
|
||
| ~~~markdown | ||
| # <Title> | ||
|
|
||
| <2-3 sentence summary> | ||
|
|
||
| <details> | ||
| <summary>Technical changes</summary> | ||
|
|
||
| - Detail 1 | ||
| - Detail 2 | ||
| - ... | ||
|
|
||
| </details> | ||
| ~~~ | ||
|
|
||
| Omit the Highlights section entirely for internal-only PRs — don't force it. | ||
|
|
||
| ### Style Rules | ||
|
|
||
| #### Title | ||
| - Imperative mood, start with a verb (Add, Fix, Refactor, etc.) | ||
| - Summarize the entire PR scope — not just one commit | ||
|
|
||
| #### Summary | ||
| - **2-3 sentences max.** This is the elevator pitch, not the full story. | ||
| - **Open with a touch of personality.** One line that makes the reader smile — a wry observation, a lighthearted remark, a playful metaphor. Not forced, just human. Examples of the energy (don't copy these literally, invent your own each time): | ||
| - "This one's mostly about cleaning house." | ||
| - "Turns out the type checker was right to complain." | ||
| - A playful metaphor about what the code was doing wrong | ||
| - A wry observation about the state of things before this PR | ||
| - **Then say what the PR does at a high level.** Name the main change areas (new feature, refactor target, bug fixed) but don't enumerate every file. The personality is in *how* you describe the changes, not in being vague. | ||
| - **Do not repeat what Highlights or Technical changes already cover.** The summary is the "why" and the big picture; details live below. | ||
|
|
||
| #### Highlights (only when applicable) | ||
| - One bullet per user-facing feature, behavior change, or notable improvement. | ||
| - Write from the user's perspective — what they'll notice, not internal implementation. | ||
| - Plain language, no code references. "Schedules now respect your configured timezone" not "`SchedulerService` gains a `timezone` attribute". | ||
| - 3-7 bullets is the sweet spot. If you can only think of 1-2, fold them into the summary and skip this section. | ||
|
|
||
| #### Technical changes (inside the accordion) | ||
| - One bullet per discrete change. Be specific — name files, classes, functions, patterns. | ||
| - Format: `backtick code references` for identifiers, plain text for descriptions. | ||
| - Every meaningful change in the diff must have a bullet. If a change touches security (CORS, auth, SQL injection), error handling, accessibility, or concurrency, it gets its own bullet — do not bury these. | ||
| - Bullets should describe the mechanism, not just the intent. "Race condition in `get_or_create_chat` fixed by moving creation inside the lookup session" is good. "Fix database issues" is not. | ||
| - Group related changes together (all typing fixes, all security hardening, all API changes, etc.) | ||
|
|
||
| #### General | ||
| - **No test plan section.** Do not include "Test plan" or "Testing". | ||
| - **No mention of tests.** Do not reference test files, test results, or testing. | ||
| - **No emoji.** | ||
| - **No "Generated by" footer.** |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,3 +216,4 @@ frontend/node_modules/ | |
| .marketing | ||
| prompture_cost_tracking.md | ||
| prompture_tracking_migration.md | ||
| /.pr | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,31 @@ | ||
| """AgentSite engine — pipeline execution, project management, and assets.""" | ||
|
|
||
| from .asset_handler import AssetHandler | ||
| from .component import GenerationConfig, GenerationResult, generate_website, regenerate_page | ||
| from .component import ( | ||
| ConversationMessage, | ||
| GenerationConfig, | ||
| GenerationResult, | ||
| PageState, | ||
| ProjectState, | ||
| delete_project, | ||
| generate_website, | ||
| load_project, | ||
| regenerate_page, | ||
| ) | ||
| from .pipeline import GenerationPipeline | ||
| from .project_manager import ProjectManager | ||
|
|
||
| __all__ = [ | ||
| "AssetHandler", | ||
| "ConversationMessage", | ||
| "GenerationConfig", | ||
| "GenerationPipeline", | ||
| "GenerationResult", | ||
| "PageState", | ||
| "ProjectManager", | ||
| "ProjectState", | ||
| "delete_project", | ||
| "generate_website", | ||
| "load_project", | ||
| "regenerate_page", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenerationConfiggained new fields (max_review_iterations,review_threshold,cancel_event,conversation_context) but the README table doesn't list them. Please document these fields (and defaults/behavior) so embedders know how to enable review gating and cancellation/context features.