Skip to content

Add additional features to cron job template #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgnagy merged 1 commit into from
Jun 18, 2025
Merged

Add additional features to cron job template #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/metatron/templates/cron_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@ class CronJob < Template

attr_accessor :schedule, :suspend, :concurrency_policy, :starting_deadline_seconds,
:successful_jobs_history_limit, :failed_jobs_history_limit,
:backoff_limit
:job_active_deadline_seconds, :ttl_seconds_after_finished,
:backoff_limit, :time_zone

alias backoffLimit backoff_limit
alias concurrencyPolicy concurrency_policy
alias startingDeadlineSeconds starting_deadline_seconds
alias successfulJobsHistoryLimit successful_jobs_history_limit
alias failedJobsHistoryLimit failed_jobs_history_limit
alias timeZone time_zone
alias ttlSecondsAfterFinished ttl_seconds_after_finished

def initialize(name, schedule = "* * * * *")
super(name)
Expand All @@ -40,9 +43,12 @@ def render
startingDeadlineSeconds:,
successfulJobsHistoryLimit:,
failedJobsHistoryLimit:,
timeZone:,
jobTemplate: {
spec: {
backoffLimit:
activeDeadlineSeconds: job_active_deadline_seconds,
backoffLimit:,
ttlSecondsAfterFinished:
}.merge(pod_template).compact
}.merge(formatted_tolerations).compact
}.compact
Expand Down
4 changes: 4 additions & 0 deletions spec/metatron/templates/cron_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
}
cron_job.containers << container
cron_job.active_deadline_seconds = 10
cron_job.job_active_deadline_seconds = 30
cron_job.annotations = { "a.test/foo": "bar" }
cron_job.additional_labels[:foo] = "bar"
cron_job.backoff_limit = 5
Expand All @@ -66,6 +67,7 @@
cron_job.starting_deadline_seconds = 10
cron_job.successful_jobs_history_limit = 5
cron_job.suspend = false
cron_job.ttl_seconds_after_finished = 3600
cron_job
end

Expand All @@ -88,7 +90,9 @@
suspend: false,
jobTemplate: {
spec: {
activeDeadlineSeconds: 30,
backoffLimit: 5,
ttlSecondsAfterFinished: 3600,
template: {
metadata: { labels: { "metatron.therubyist.org/name": "hello" } },
spec: {
Expand Down