Skip to content

Fix compatibility issue with JfrogContextMenuHandler interface #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kerenr-jfrog wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix compatibility issue with JfrogContextMenuHandler interface #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/com/jfrog/ide/idea/ui/JfrogContextMenuHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.cef.browser.CefFrame;
import org.cef.callback.CefContextMenuParams;
import org.cef.callback.CefMenuModel;
import org.cef.callback.CefRunContextMenuCallback;
import org.cef.handler.CefContextMenuHandler;

import javax.swing.*;
Expand Down Expand Up @@ -41,4 +42,11 @@ private void openDevTools(CefBrowser browser) {
@Override
public void onContextMenuDismissed(CefBrowser browser, CefFrame frame) {
}

@Override
public boolean runContextMenu(CefBrowser browser, CefFrame frame, CefContextMenuParams params, CefMenuModel model, CefRunContextMenuCallback callback) {
// Return false to use the default context menu handling
// This maintains the existing behavior while implementing the required method for IntelliJ 2025+
return false;
}
}
Loading