feat: Add GetTokens, GetTokensByID, RevokeTokenByID methods #1255

legnoh · 2025-10-30T03:45:04Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the master branch.
I used gofmt for formatting the code before submitting the pull request.

This pull request adds new functionality to manage access tokens more effectively, including retrieving and revoking tokens by ID, as well as filtering and listing tokens. It introduces new methods in the access token service and manager, updates the documentation, and adds comprehensive tests for these features.

New Access Token Management Features:

Added methods to TokenService and AccessServicesManager for:
- Listing tokens with filters (GetTokens)
  - https://jfrog.com/help/r/jfrog-rest-apis/get-tokens
- Retrieving a token by ID (GetTokenByID)
  - https://jfrog.com/help/r/jfrog-rest-apis/get-token-by-id
- Revoking a token by ID (RevokeTokenByID) [1] [2] [3]
  - https://jfrog.com/help/r/jfrog-rest-apis/revoke-token-by-id
Introduced new parameter and response types:
- GetTokensParams, TokenInfo, and TokenInfos structs for handling token queries and responses

Documentation Updates:

Expanded the README.md to document:
- How to get access tokens (with filters)
- How to get a token by ID
- How to revoke a token by ID [1] [2]

Testing Enhancements:

Added tests for the new access token methods:
- testGetTokens
- testGetTokenByID
- testRevokeTokenByID [1] [2]

These changes make it easier to programmatically manage access tokens, improving both usability and test coverage.

…GetTokenByID tests

…sername

abhisheksaxena29 · 2025-12-11T12:04:31Z

README.md

+    Username:        "admin",                     // Filter by username
+    Refreshable:     utils.Pointer(true),         // Filter by refreshable status
+    TokenId:         "token-id",                  // Filter by specific token ID
+    OrderBy:         "issued_at",                 // Order by field (issued_at, expires_at, etc.)


// Order by field (created,token_id,owner,subject,expiry)
https://jfrog.com/help/r/jfrog-rest-apis/get-tokens

You're right — the information was inaccurate. I'll correct it!

I've made the correction!

abhisheksaxena29 · 2025-12-11T12:06:21Z

access/services/accesstoken.go

+	}
+	if params.LastUsed != nil {
+		queryParams.Add("last_used", strconv.FormatInt(*params.LastUsed, 10))
+	}


last_used should be removed as it is not supported by the backend

When I look at the document below, it suggests in a Note that the last_used parameter is available under certain conditions — is that not correct?
https://jfrog.com/help/r/jfrog-rest-apis/get-tokens

The Note holds true for the response payload. But its not supported as query param

Understood. I've made the correction, so please take a look.

0x01F4 · 2025-12-16T09:16:32Z

access/services/accesstoken.go

+	if err != nil {
+		return err
+	}
+	return errorutils.CheckResponseStatusWithBody(resp, body, http.StatusOK)


Add http.StatusNoContent as well.API will return 204 incase if token doesn't exist or already revoked.

* Add retry to POST build scan trigger if needed * retry err as suffix * build name can be not alphabet * fix regex number * use retry * add debug log * fix tests

* Xray Remediation Service * add remediation service to xray manager * rename facade method * start adding tests for new API * switch to new API * start fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * add content type * fix attribs in resp struct * CR changes

* Removed repo field in AQL query * Updated test case

…#1265) * Fix an issue that evidence encoded url twice resulting in a wrong url * Add evidence client mock in order to make evidence APIs more accurate in evidence tests

* Xray Get Violations API * change upload log to debug * fix log remove file * add NewWatchRepositoryByName * fix create watch body * format * CR changes * add LineNumber to API

Co-authored-by: remib <[email protected]>

* Fix application details resolution from api * Add new fields for criticality and maturity to README

* added git integration post request * added function to XscService interface * added SendGitIntegrationEvent to xsc inner service * after cr

* Fix Remediation after API breaking change * add more changes to the API * fix test

* malicious-code-scanner * malicious-code-scanner

* updated CC structs and comparison file * removing DisplayFixableOnly and MinSeverityToDisplay * setting back ConfigProfileNewSchemaMinXrayVersion

github-actions · 2025-12-17T09:28:08Z

🐸 JFrog Frogbot

legnoh · 2025-12-17T09:37:53Z

The upstream merge ended up in an odd state, so I'll recreate the PR.
Sorry for the trouble....

legnoh · 2025-12-17T09:57:43Z

@0x01F4 @abhisheksaxena29 I recreated the PR(#1282) to ensure the diff is applied correctly.
I would appreciate it if you could review it again 🙇

legnoh added 2 commits October 30, 2025 12:35

feat: add access token management APIs

2d645f9

refactor: wrap mock response in TokenInfos structure for GetTokens test

e0c8835

ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2025

legnoh marked this pull request as draft October 30, 2025 03:55

legnoh changed the title ~~Add get tokens by~~ Add GetTokens, GetTokensByID, RevokeTokenByID methods Oct 30, 2025

fix: update token structure to include Issuer field in GetTokens and …

0d568be

…GetTokenByID tests

ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2025

fix: update token tests to use Subject and Issuer fields instead of U…

bcf85b0

…sername

ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2025

refactor: remove unused createRefreshableAccessTokenParams function

78cc2ce

ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 30, 2025

legnoh changed the title ~~Add GetTokens, GetTokensByID, RevokeTokenByID methods~~ feat: Add GetTokens, GetTokensByID, RevokeTokenByID methods Oct 30, 2025

legnoh marked this pull request as ready for review October 30, 2025 04:16

abhisheksaxena29 reviewed Dec 11, 2025

View reviewed changes

legnoh added 2 commits December 12, 2025 18:32

fix: update OrderBy field in GetTokensParams document

f4f5af1

refactor: remove LastUsed field from GetTokensParams and related logic

6f189fb

0x01F4 reviewed Dec 16, 2025

View reviewed changes

fix: update response status check in RevokeTokenByID to handle NoContent

726af38

0x01F4 approved these changes Dec 17, 2025

View reviewed changes

attiasas and others added 6 commits December 17, 2025 18:25

Add retry to POST build scan trigger if needed (#1252)

4220434

* Add retry to POST build scan trigger if needed * retry err as suffix * build name can be not alphabet * fix regex number * use retry * add debug log * fix tests

JGC-427 - Skip broken repositories tests (#1256)

bf54a5c

Removed repo field in AQL query (#1258)

1eb2f9c

* Removed repo field in AQL query * Updated test case

support for direct-download cmd (#1199)

73f9f67

JGC-429 - Bump go 1.25 (#1259)

09b78c6

dortam888 and others added 15 commits December 17, 2025 18:25

Fix get details API (#1260)

9ccf6d8

update build-info-go dependency (#1262)

d3570d1

changing the build-info-go version

8194171

Fix an issue that evidence encoded url twice resulting in a wrong url (…

b347e35

…#1265) * Fix an issue that evidence encoded url twice resulting in a wrong url * Add evidence client mock in order to make evidence APIs more accurate in evidence tests

Xray Get Violations API (#1186)

c687c13

* Xray Get Violations API * change upload log to debug * fix log remove file * add NewWatchRepositoryByName * fix create watch body * format * CR changes * add LineNumber to API

JGC-000 - Remove auto label (#1266)

f03db7b

Co-authored-by: remib <[email protected]>

Fix application details resolution from api (#1268)

c2ab78e

* Fix application details resolution from api * Add new fields for criticality and maturity to README

On-demand log level to debug and set props recursively for props (#1269)

e25eff5

Git Integration POST Request (#1272)

9742f99

* added git integration post request * added function to XscService interface * added SendGitIntegrationEvent to xsc inner service * after cr

Fix Remediation after API breaking change (#1275)

67d0ca2

* Fix Remediation after API breaking change * add more changes to the API * fix test

Fix: Handle Empty/Uninitialized .git Directory Gracefully (#1277)

9798380

Fix: Temp Directory Cleanup Continues on Permission Errors (#1276)

23fc9f0

malicious-code-scanner (#1080)

8f9334e

* malicious-code-scanner * malicious-code-scanner

Align config profile structure to recent changes in API body (#1274)

1b73690

* updated CC structs and comparison file * removing DisplayFixableOnly and MinSeverityToDisplay * setting back ConfigProfileNewSchemaMinXrayVersion

fixed TestXscSendGitIntegrationEvent (#1281)

cbf1b0d

legnoh closed this Dec 17, 2025

legnoh mentioned this pull request Dec 17, 2025

feat: Add GetTokens, GetTokensByID, RevokeTokenByID methods #1282

Open

4 tasks

feat: Add GetTokens, GetTokensByID, RevokeTokenByID methods #1255

feat: Add GetTokens, GetTokensByID, RevokeTokenByID methods #1255

Uh oh!

Conversation

legnoh commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legnoh Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

legnoh commented Dec 17, 2025

Uh oh!

legnoh commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

legnoh commented Oct 30, 2025 •

edited

Loading

legnoh Dec 12, 2025 •

edited

Loading