Skip to content

RTECO-1003 - Fix teardown_env: use resource property syntax for SERVER_NAME#3469

Merged
naveenku-jfrog merged 2 commits intomasterfrom
jfrogpipelines
May 5, 2026
Merged

RTECO-1003 - Fix teardown_env: use resource property syntax for SERVER_NAME#3469
naveenku-jfrog merged 2 commits intomasterfrom
jfrogpipelines

Conversation

@naveenku-jfrog
Copy link
Copy Markdown
Collaborator

${server_name}pipeline variable is not resolved in Jenkins step buildParameters (only available in bash execution blocks). Usecli${res_cli_coreapps_env_details_suffix}— the same pattern already used indeploy_environment` — so Jenkins receives a non-empty SERVER_NAME and the environment_operate job no longer fails with "ACTION and SERVER_NAME are mandatory parameters".

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
…R_NAME

The plain pipeline variable ${server_name} is not resolved inside a
Jenkins step's buildParameters (it is only available in bash execution
blocks). Fix by writing the server name components to the
cli_coreapps_env_details resource in setup_cli_test and reading them
back with the ${res_<resource>_<key>} syntax that JFrog Pipelines
resolves at the configuration level:

  prefix="${server_name%${suffix}}"
  write_output "cli_coreapps_env_details" "prefix=${prefix}"
  write_output "cli_coreapps_env_details" "suffix=${suffix}"

Both deploy_environment and teardown_env now compose SERVER_NAME as:
  "${res_cli_coreapps_env_details_prefix}${res_cli_coreapps_env_details_suffix}"

This removes the hardcoded "cli" literal and fixes the Jenkins job
failing with "ACTION and SERVER_NAME are mandatory parameters".

Co-authored-by: Cursor <[email protected]>
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 5, 2026
@naveenku-jfrog naveenku-jfrog merged commit 7d7713b into master May 5, 2026
117 of 259 checks passed
@naveenku-jfrog naveenku-jfrog deleted the jfrogpipelines branch May 5, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants