-
Notifications
You must be signed in to change notification settings - Fork 296
Jfrogpipelines #3422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jfrogpipelines #3422
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,17 @@ | ||
| name: Plugins Tests | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| jfrog_url: | ||
| description: "External JFrog Platform URL. Leave empty for local Artifactory." | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| jfrog_admin_token: | ||
| description: "Admin token for external JFrog Platform." | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| push: | ||
| branches: | ||
| - "master" | ||
|
|
@@ -72,8 +83,12 @@ jobs: | |
| uses: jfrog/.github/actions/install-local-artifactory@main | ||
| with: | ||
| RTLIC: ${{ secrets.RTLIC }} | ||
| JFROG_URL: ${{ inputs.jfrog_url }} | ||
| JFROG_ADMIN_TOKEN: ${{ inputs.jfrog_admin_token }} | ||
| RT_CONNECTION_TIMEOUT_SECONDS: ${{ env.RT_CONNECTION_TIMEOUT_SECONDS || '1200' }} | ||
|
|
||
| - name: Run plugins tests | ||
| if: matrix.os.name != 'macos' | ||
| run: go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins | ||
| run: >- | ||
| go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins | ||
| ${{ env.JFROG_TESTS_IS_EXTERNAL == 'true' && format('--jfrog.url={0} --jfrog.adminToken={1}', env.JFROG_TESTS_URL, env.JFROG_TESTS_LOCAL_ACCESS_TOKEN) || '' }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since token is used here, does tests leak the token used fr tests? were you able to verify?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the already used style in all workflows. Refer: https://github.com/jfrog/jfrog-cli/blob/master/.github/workflows/artifactoryTests.yml#L82 |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like repeating pattern fr all the files can it be made generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions has no mechanism to share or inherit workflow_dispatch input definitions across workflow files. Each file must declare its own inputs independently — this is a documented platform limitation, not a design choice we can easily escape.