Skip to content

add conan build info support #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reshmifrog wants to merge 4 commits into from
Closed

add conan build info support #3268

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f43bba
add conan build info support
reshmifrog Dec 12, 2025
c6bc953
update dependencies:
reshmifrog Dec 12, 2025
1901558
resolve conflicts
reshmifrog Dec 23, 2025
8529df2
Merge branch 'master' into feature/support-conan-build-info
reshmifrog Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions buildtools/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"github.com/jfrog/jfrog-cli/docs/buildtools/rubyconfig"
setupdocs "github.com/jfrog/jfrog-cli/docs/buildtools/setup"

conancommand "github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/conan"

Check failure on line 24 in buildtools/cli.go

View workflow job for this annotation

GitHub Actions / Lint 

no required module provides package github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/conan; to add it:
"github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/container"
"github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/dotnet"
"github.com/jfrog/jfrog-cli-artifactory/artifactory/commands/golang"
Expand Down Expand Up @@ -1486,18 +1487,21 @@
}

args := cliutils.ExtractCommand(c)
cmdName, conanArgs := getCommandName(args)
filteredArgs, buildConfiguration, err := build.ExtractBuildDetailsFromArgs(args)
if err != nil {
return err
}
cmdName, conanArgs := getCommandName(filteredArgs)

// Execute native conan command directly
log.Info(fmt.Sprintf("Running Conan %s.", cmdName))
conanCmd := exec.Command("conan", append([]string{cmdName}, conanArgs...)...)
conanCmd.Stdout = os.Stdout
conanCmd.Stderr = os.Stderr
if err := conanCmd.Run(); err != nil {
return fmt.Errorf("conan %s failed: %w", cmdName, err)
// Create and configure Conan command
conanCmd := conancommand.NewConanCommand()
conanCmd.SetCommandName(cmdName).SetArgs(conanArgs)

if buildConfiguration != nil {
conanCmd.SetBuildConfiguration(buildConfiguration)
}

return nil
return conanCmd.Run()
}

func pythonCmd(c *cli.Context, projectType project.ProjectType) error {
Expand Down
Loading