Skip to content

Conversation

@kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Dec 10, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

  • Added logic for cases we want to compare between SBOM components from two different scans and exclude the similar components.

@kerenr-jfrog kerenr-jfrog self-assigned this Dec 10, 2025
@kerenr-jfrog kerenr-jfrog added bug Something isn't working safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 16, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please add another test case where PackageURL values has the hash suffix so you can see it works

@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 17, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to merge dev before merge

@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2025
@kerenr-jfrog kerenr-jfrog added the safe to test Approve running integration tests on a pull request label Dec 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2025
@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@kerenr-jfrog kerenr-jfrog merged commit 6976bb9 into jfrog:dev Dec 24, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants