Frogbot Configuration Refactor #993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orto17
commented
Dec 10, 2025
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
eyalk007
reviewed
Dec 11, 2025
| } | ||
| scanDetails = utils.NewScanDetails(client, &repoConfig.Server, &repoConfig.Params.Git). | ||
| return utils.NewScanDetails(client, &repoConfig.Server, &repoConfig.Params.Git). | ||
| SetJfrogVersions(repoConfig.Params.XrayVersion, repoConfig.Params.XscVersion). |
Contributor
There was a problem hiding this comment.
what if we also killed xsc version and told cli to kill it s well?
eyalk007
reviewed
Dec 11, 2025
Comment on lines
24
to
49
| func GetCompatiblePackageHandler(vulnDetails *utils.VulnerabilityDetails, details *utils.ScanDetails) (handler PackageHandler) { | ||
| switch vulnDetails.Technology { | ||
| case techutils.Go: | ||
| handler = &GoPackageHandler{} | ||
| case techutils.Poetry: | ||
| handler = &PythonPackageHandler{} | ||
| case techutils.Pipenv: | ||
| handler = &PythonPackageHandler{} | ||
| case techutils.Npm: | ||
| handler = &NpmPackageHandler{} | ||
| case techutils.Yarn: | ||
| handler = &YarnPackageHandler{} | ||
| case techutils.Pip: | ||
| handler = &PythonPackageHandler{pipRequirementsFile: details.PipRequirementsFile} | ||
| handler = &PythonPackageHandler{pipRequirementsFile: defaultRequirementFile} | ||
| case techutils.Maven: | ||
| handler = NewMavenPackageHandler(details) | ||
| case techutils.Nuget: | ||
| handler = &NugetPackageHandler{} | ||
| case techutils.Gradle: | ||
| handler = &GradlePackageHandler{} | ||
| case techutils.Pnpm: | ||
| handler = &PnpmPackageHandler{} | ||
| case techutils.Conan: | ||
| handler = &ConanPackageHandler{} | ||
| default: | ||
| handler = &UnsupportedPackageHandler{} |
Contributor
There was a problem hiding this comment.
if you in the mood of refactoring make it a mapping object instead of this insane switch case
this isnt logic switching this is a pure factory
eyalk007
reviewed
Dec 11, 2025
| return | ||
| } | ||
| return | ||
|
|
eyalk007
reviewed
Dec 11, 2025
| type ScanPullRequestCmd struct{} | ||
|
|
||
| func (cmd *ScanPullRequestCmd) Run(repository utils.Repository, client vcsclient.VcsClient, frogbotRepoConnection *utils.UrlAccessChecker) (err error) { | ||
| func (cp *ScanPullRequestCmd) Run(repository utils.Repository, client vcsclient.VcsClient, frogbotRepoConnection *utils.UrlAccessChecker) (err error) { |
eyalk007
reviewed
Dec 11, 2025
| client vcsclient.VcsClient | ||
| fixableOnly bool | ||
| skipAutoInstall bool | ||
| minSeverityFilter severityutils.Severity |
eyalk007
reviewed
Dec 11, 2025
| SetUseWrapper(*sc.UseWrapper). | ||
| SetMaxTreeDepth(sc.MaxPnpmTreeDepth). | ||
| SetDepsRepo(sc.DepsRepo). | ||
| SetIgnoreConfigFile(true). |
Contributor
There was a problem hiding this comment.
i checked with assaf we dont even need to pass it it's some weird legacy no one uses
eyalk007
reviewed
Dec 11, 2025
| GitProvider = "JF_GIT_PROVIDER" | ||
| GitRepoOwnerEnv = "JF_GIT_OWNER" | ||
| GitRepoEnv = "JF_GIT_REPO" | ||
| GitProjectEnv = "JF_GIT_PROJECT" |
Contributor
There was a problem hiding this comment.
@eranturgeman suggested to call it something like JF_AZURE_GIT_PROJECT
as its specific to azure and i agree
eyalk007
reviewed
Dec 11, 2025
|
|
||
| // The 'GITHUB_ACTIONS' environment variable exists when the CI is GitHub Actions | ||
| GitHubActionsEnv = "GITHUB_ACTIONS" | ||
| GitHubActionsEnv = "GITHUB_ACTIONS" // TODO WHAT IS THIS? |
eyalk007
reviewed
Dec 11, 2025
| scanDetails *utils.ScanDetails | ||
| // The base working directory | ||
| baseWd string | ||
| baseWd string //TODO |
Contributor
There was a problem hiding this comment.
what does the todo mean? to do what?
eyalk007
reviewed
Dec 11, 2025
| ApiEndpoint string | ||
| PullRequestID string | ||
| CustomBranchName string | ||
| UseLocalRepo bool |
Contributor
There was a problem hiding this comment.
dont you need to delete this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.