-
Notifications
You must be signed in to change notification settings - Fork 88
Created new release using workflows and deleted old one #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eyalk007
wants to merge
29
commits into
jfrog:v3_er
Choose a base branch
from
eyalk007:create-new-release
base: v3_er
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match old pipeline
* fix python descriptor file resolution * added comment for readability
- Add workflow_dispatch trigger with version input parameter - Validate version is v3.x.x format - Check if tag already exists before proceeding - Auto-generate release notes at the end - Set make_latest=false to not mark as latest release - Improve failure cleanup to work with both trigger types
- Create Go builder tool that builds all 10 platform binaries concurrently - Replace sequential bash script with parallel Go implementation - Build linux-386 first for version verification, then build remaining 9 in parallel - Should significantly reduce build time from ~10+ minutes to ~2-3 minutes - All builds run concurrently without worker limits for maximum speed
- Update buildAndUpload.sh to run 9 builds in parallel using & background jobs - Build linux-386 first for version verification, then all others concurrently - Simpler solution than Go - just ~20 lines added to existing bash script - All builds run on same runner, no worker limits for maximum speed - Should reduce build time from ~10-15 minutes to ~2-3 minutes
- Each build now outputs to unique filename (e.g., frogbot-linux-amd64) - Prevents parallel builds from overwriting each other's binaries - Upload still uses correct final name 'frogbot' at destination - Fixes checksum mismatch errors when uploading
- Add step to download all dependencies once before parallel builds start - Runs go mod download and go list to populate cache - Prevents 9 parallel builds from racing to download same dependencies - Should reduce parallel build time by avoiding redundant work
- Remove jf audit step - Build and run Frogbot scan-repository on itself - True dogfooding: Frogbot scanning Frogbot 🐸 - Fails if vulnerabilities found
- Replace manual go build + run with jfrog/frogbot@v2 action - Simpler, faster, and more reliable - Added JF_FAIL flag to fail on security issues
- Frogbot will scan and fail on issues - Won't attempt to create automatic fix pull requests
- Replace 'jf go build' with 'go build' to remove JFrog CLI overhead - Add cache warmup step before parallel builds - Pre-download dependencies once - Warm up Go build cache with initial build - Should significantly reduce parallel build time from 6min to 2-3min
This reverts commit edfd425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.