Skip to content

AppTrust: Evaluation integration into scan-pull-request flow #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eranturgeman wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

AppTrust: Evaluation integration into scan-pull-request flow #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scanpullrequest/scanpullrequest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,13 @@ func auditPullRequestAndReport(repoConfig *utils.Repository, client vcsclient.Vc
)
}
}()
/* TODO eran
we need to insert somewhere the following logic:
If in app-context, call Evaluation API somewhere and get the 'missing_data' that indicates the missing scans (for the relevant msi).
those missing scans must be performed and they are overriding CC, frogbot-apps, or any other source that can decide which scans we run
After the scans are completed (must be completed) we call the Evaluation api again to get the Allow/Deny status and act accordingly with the fail logic.
*/

// Audit PR code
issuesCollection, err = auditPullRequestCode(repoConfig, scanDetails, sourceBranchWd, targetBranchWd)
return
Expand Down
Loading