Make the progressbar and ruby-progressbar gems only differ in their names, but have the exact same content. #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….rb or ruby-progessbar.rb Having the 2 gems with quite the same content but not exactly is very confusing, for instance on Debian because the ruby-progressbar deb package actually contains the progressbar gem, not the ruby-progressbar gem. IMHO, having both gems with the exact same content would be more user-friendly, allowing 'require "progressbar"' and 'require "ruby-progressbar"' indifferently from what gem is actually installed (be it with gem install or a distrubution package).
…ntent) It's the same content. Removes the duplication of code. Avoid possible divergence.
|
@npf Why does the |
I believe the package is intended to contain the Or in other words, the same reason that the deb |
|
Thanks for the reply! Unfortunately this is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Make the progressbar and ruby-progressbar gems only differ in their names, but have the exact same content.
Let both the ruby-progressbar and progressbar gems allow requiring progressbar or ruby-progessbar indifferently.
Why: Having the 2 gems with quite the same content but not exactly is very
confusing, for instance, on Debian because the ruby-progressbar deb
package contains the progressbar gem, not the ruby-progressbar
gem.
IMHO, having both gems with the exact same content would be more
user-friendly, allowing 'require "progressbar"' and 'require
"ruby-progressbar"' indifferently, independently of what gem is actually installed
(be it with gem install or a distribution package).