Fix for G2 and G3 arc interpolation code#42
Open
Anoyomouse wants to merge 1 commit intojetty840:masterfrom
Open
Fix for G2 and G3 arc interpolation code#42Anoyomouse wants to merge 1 commit intojetty840:masterfrom
Anoyomouse wants to merge 1 commit intojetty840:masterfrom
Conversation
Arc interpolation was using a single reference to the point, which was being changed on every step generating a 0 delta, which means the arc was effectively generating a single line for arcs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arc interpolation was using a single reference to the point, which was
being changed on every step generating a 0 delta, which means the arc
was effectively generating a single line for arcs
this fixes that reference issue
Also, the previous time i attempted to fix this issue it was pushed back with the fact it doesn't support 5D, the problem isn't anything to do with 5D and will affect 2D or 3D generation as well, effectively collapsing the Arc into a straight line