WIP:Add architecture and os checks when fetching tags #60

tfadeyi · 2020-11-16T09:21:55Z

This updates the controller to check the architecture of the cluster
nodes and select only tags for the current architecture.

Going to handle the composite hashes in a following PR.

needs: #61

Signed-off-by: oluwole.fadeyi [email protected]

jetstack-bot · 2020-11-16T09:21:57Z

@tfadeyi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/api/types.go

pkg/controller/architecture/architecture.go

JoshVanL

Generally looking good, hope my comments make sense 😄

pkg/controller/architecture/architecture.go

pkg/controller/controller.go

pkg/controller/options/options.go

pkg/controller/search/search.go

pkg/metrics/metrics.go

pkg/version/version.go

pkg/api/types.go

JoshVanL

Looking good, few more comments from me 🙂

JoshVanL · 2020-11-17T14:47:30Z

deploy/yaml/deploy.yaml

@@ -62,7 +62,7 @@ metadata:
  name: version-checker
 rules:
 - apiGroups: [""]
-  resources: ["pods"]
+  resources: ["pods","nodes"]


We also need to update deploy/yaml/deploy.yaml

do you mean the Helm chart?

Isn't the deploy/yaml/deploy.yaml changed already?

pkg/api/types.go

pkg/checker/architecture/architecture.go

JoshVanL · 2020-11-17T14:51:18Z

pkg/checker/architecture/architecture_test.go

+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	utils "github.com/jetstack/version-checker/pkg/checker/internal/testutils"


❤️

nit: can we testutils -> test

pkg/controller/nodes/informer.go

pkg/metrics/metrics.go

This updates the controller to check the architecture of the cluster nodes and select only tags for the current architecture. Signed-off-by: oluwole.fadeyi <[email protected]>

JoshVanL · 2020-11-19T12:40:12Z

/hold
/approve
/lgtm

jetstack-bot · 2020-11-19T12:40:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, tfadeyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoshVanL]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot · 2023-01-03T23:58:39Z

@tfadeyi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawksight · 2024-04-11T07:44:31Z

Hey @tfadeyi, this has been open a while and needs a rebase at least.

Are you interested in updating this branch and getting this feature into version-checker?
If not I can try to see if someone else can take over here.

tfadeyi · 2024-04-11T09:19:17Z

Hey @tfadeyi, this has been open a while and needs a rebase at least.

Are you interested in updating this branch and getting this feature into version-checker? If not I can try to see if someone else can take over here.

Hey @hawksight I think we could have someone take over, or close this PR. I don't fully remember but there were some edge cases with multi-arch images that this PR won't cover

hawksight · 2024-04-25T08:55:50Z

@tfadeyi - thanks for feedback.

We will close this as it's quite old but use it as a good reference point for a new implementation from a fresh branch.

Created #181 to track discussion / progress on the topic.

tfadeyi self-assigned this Nov 16, 2020

jetstack-bot added the do-not-merge/work-in-progress label Nov 16, 2020

jetstack-bot added dco-signoff: yes do-not-merge/release-note-label-needed labels Nov 16, 2020

jetstack-bot requested a review from JoshVanL November 16, 2020 09:21

jetstack-bot added the size/L label Nov 16, 2020

tfadeyi force-pushed the 58-add-arch-and-os-checks branch 2 times, most recently from 0192ae2 to 66007c1 Compare November 16, 2020 15:01

tfadeyi changed the title ~~WIP: Add architecture and os checks when fetching tags~~ Add architecture and os checks when fetching tags Nov 16, 2020

jetstack-bot removed the do-not-merge/work-in-progress label Nov 16, 2020

tfadeyi force-pushed the 58-add-arch-and-os-checks branch from 66007c1 to 79273fa Compare November 16, 2020 15:26

JoshVanL reviewed Nov 16, 2020

View reviewed changes

pkg/api/types.go Outdated Show resolved Hide resolved

pkg/controller/architecture/architecture.go Outdated Show resolved Hide resolved

pkg/controller/architecture/architecture.go Outdated Show resolved Hide resolved

pkg/controller/architecture/architecture.go Outdated Show resolved Hide resolved

JoshVanL suggested changes Nov 16, 2020

View reviewed changes

pkg/version/version.go Outdated Show resolved Hide resolved

pkg/api/types.go Outdated Show resolved Hide resolved

tfadeyi changed the title ~~Add architecture and os checks when fetching tags~~ WIP:Add architecture and os checks when fetching tags Nov 16, 2020

jetstack-bot added the do-not-merge/work-in-progress label Nov 16, 2020

tfadeyi force-pushed the 58-add-arch-and-os-checks branch from 79273fa to 0c3371c Compare November 16, 2020 23:50

jetstack-bot added size/XL and removed size/L labels Nov 16, 2020

tfadeyi force-pushed the 58-add-arch-and-os-checks branch 3 times, most recently from f3c85b3 to 4f8160f Compare November 17, 2020 13:03

JoshVanL suggested changes Nov 17, 2020

View reviewed changes

tfadeyi force-pushed the 58-add-arch-and-os-checks branch 2 times, most recently from 8ed61f9 to 5c5d535 Compare November 18, 2020 16:29

Add architecture and os checks when fetching tags

4bab9ef

This updates the controller to check the architecture of the cluster nodes and select only tags for the current architecture. Signed-off-by: oluwole.fadeyi <[email protected]>

tfadeyi force-pushed the 58-add-arch-and-os-checks branch from 5c5d535 to 4bab9ef Compare November 18, 2020 16:33

jetstack-bot added the do-not-merge/hold label Nov 19, 2020

jetstack-bot assigned JoshVanL Nov 19, 2020

jetstack-bot added the lgtm label Nov 19, 2020

jetstack-bot added the approved label Nov 19, 2020

jetstack-bot added the needs-rebase label Jan 3, 2023

hawksight mentioned this pull request Apr 11, 2024

Write version-checker roadmap #173

Closed

hawksight closed this Apr 25, 2024

davidcollom mentioned this pull request Jun 25, 2024

Adding OS/Arch Support #212

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP:Add architecture and os checks when fetching tags #60

WIP:Add architecture and os checks when fetching tags #60

tfadeyi commented Nov 16, 2020 •

edited

Loading

jetstack-bot commented Nov 16, 2020

JoshVanL left a comment

JoshVanL left a comment

JoshVanL Nov 17, 2020

tfadeyi Nov 18, 2020

JoshVanL Nov 17, 2020

JoshVanL commented Nov 19, 2020

jetstack-bot commented Nov 19, 2020

jetstack-bot commented Jan 3, 2023

hawksight commented Apr 11, 2024

tfadeyi commented Apr 11, 2024

hawksight commented Apr 25, 2024

WIP:Add architecture and os checks when fetching tags #60

WIP:Add architecture and os checks when fetching tags #60

Conversation

tfadeyi commented Nov 16, 2020 • edited Loading

jetstack-bot commented Nov 16, 2020

JoshVanL left a comment

Choose a reason for hiding this comment

JoshVanL left a comment

Choose a reason for hiding this comment

JoshVanL Nov 17, 2020

Choose a reason for hiding this comment

tfadeyi Nov 18, 2020

Choose a reason for hiding this comment

JoshVanL Nov 17, 2020

Choose a reason for hiding this comment

JoshVanL commented Nov 19, 2020

jetstack-bot commented Nov 19, 2020

jetstack-bot commented Jan 3, 2023

hawksight commented Apr 11, 2024

tfadeyi commented Apr 11, 2024

hawksight commented Apr 25, 2024

tfadeyi commented Nov 16, 2020 •

edited

Loading