Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using pymonocypher for a cryptographic protocol, we encountered an AttributeError:
AttributeError: 'dict' object has no attribute 'nb_block'
Using the Python console to reproduce the error with monocypher 4.0.2.3:
This will result in the following exception:
Traceback (most recent call last):
File "", line 1, in
File "c_monocypher.pyx", line 328, in monocypher.argon2i_32
AttributeError: 'dict' object has no attribute 'nb_block'
It appears that the c_monocypher.pyx is defined in the singular 'nb_block' for the binding when it should be 'nb_blocks'. After changing that value to 'nb_blocks', it works as expected:
This produces a bytes object as expected:
b'\x8cj\x88\xc7\xda}\x7f\x18Z\x01\xbf\xbb\xd5\x01\x13\xd9<\xb4\xb9'c\x8f\x98\xee\x96\x04E-\xfc"\xd9o'